steveej/dotagents
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

agent_gate-severity-tiers #1

Open
steveej wants to merge 3 commits from agent_gate-severity-tiers into master
pull from: agent_gate-severity-tiers
merge into: steveej:master
Conversation 0 Commits 3 Files changed 9 +327 -28
steveej commented 2026-11-04 21:14:11 +00:00
Owner
Copy link
No description provided. 
Why:
- Must-fix and Should-fix mixed two questions in one ladder: whether a finding blocks acceptance and how much harm it does. A harmless false claim outranked a defect that takes a runner out of service, and the gate could pass a change with such a defect open.
- The gate had no way to say that a change's goal is itself wrong; it could only pass or fail the change against it.

Changes:
- Add the Finding Classes section: every finding answers one question, Goal (is the goal right), Effect (does the change reach it) or Side effect (what else it does), or is a Follow-up item.
- Grade Goal, Effect and Side effect findings by impact, High, Medium or Low, from the effect of leaving them in place.
- Define a side effect as behavior, a test or a job that works at the change's base and no longer at its head, or an unstated new risk or cost.
- Make PASS require no unresolved Effect or Side effect finding and no unanswered High Goal finding; FAIL means an Effect or Side effect finding remains; a High Goal finding holds the verdict at UNCLEAR until the goal's owner answers.
- Group the recommended fix plan by class and impact and replace the Parking Lot section with Follow-up items.
- Require one class per finding and one impact per graded finding in the final check.
- Use the classes in milestone-close, the milestone quality-gate reference and the reviewer's formal output.
- milestone-close: drop the quotes around its frontmatter values and zero-pad its question list to two digits, matching task-quality-gate's report list.
Why:
- A design review of a merge request re-derives the problem, measures the effect and proposes alternatives, which task-quality-gate's falsification contract excludes.
- Reviews and acceptance gates should share one finding vocabulary, and an agent holding only the gate needs a pointer to the review skill.

Changes:
- Add the change-design-review skill with a read-only contract, no PASS or FAIL verdict and a hand-off to task-quality-gate for acceptance gates.
- Require nine report sections in fixed order: a Summary that names the change's invariant and its failure signal, a core-change subsection with an example, and an Assessment split into effect, impact-ordered correctness conditions with an Open: sentence each, and a risks table with Class, Impact and Signal columns.
- Take finding classes and impacts from task-quality-gate's Finding Classes, treat the change's own description, commits and thread answers as its goal and claims, and make Goal findings the review's main subject.
- Require run identities on measurements, scope predicates on counts, one row per finding, and alternatives that name the restored property in platform terms with the regular form as a snippet.
- Add references/expected-return.md and references/reproduction-plan.md with conditional index lines for return estimation and reproduction planning.
- Point task-quality-gate's description at change-design-review for a design assessment with no accepted contract.
This pull request has changes conflicting with the target branch.
  • ROADMAP.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent_gate-severity-tiers:agent_gate-severity-tiers
git switch agent_gate-severity-tiers

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff agent_gate-severity-tiers
git switch agent_gate-severity-tiers
git rebase master
git switch master
git merge --ff-only agent_gate-severity-tiers
git switch agent_gate-severity-tiers
git rebase master
git switch master
git merge --no-ff agent_gate-severity-tiers
git switch master
git merge --squash agent_gate-severity-tiers
git switch master
git merge --ff-only agent_gate-severity-tiers
git switch master
git merge agent_gate-severity-tiers
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
steveej/dotagents!1
No description provided.